Slim Homepage AB test - Slimify all sections#15487
Merged
Conversation
domlander
added
run_chromatic
domlander
force-pushed
the
doml/slim-homepage-ab-test-slimify-all
branch
from
bf90c62 to
df6c0a4
Compare
domlander
force-pushed
the
doml/slim-homepage-ab-test-slimify-all
branch
from
df6c0a4 to
dba083f
Compare
domlander
force-pushed
the
doml/slim-homepage-ab-test-slimify-all
branch
from
dba083f to
f1d4c66
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
abeddow91
reviewed
Mar 10, 2026
Comment on lines
+216
to
+232
| /** | ||
| * headline medium 20 on desktop and headline medium 17 on tablet and mobile | ||
| */ | ||
| export const defaultFontSizes: ResponsiveFontSize = { | ||
| desktop: 'xsmall', | ||
| tablet: 'xxsmall', | ||
| mobile: 'xxsmall', | ||
| }; | ||
|
|
||
| export const CardHeadline = ({ | ||
| headlineText, | ||
| format, | ||
| showQuotes, | ||
| kickerText, | ||
| showPulsingDot, | ||
| hasInlineKicker, | ||
| /** headline medium 20 on desktop and headline medium 17 on tablet and mobile */ | ||
| fontSizes = { desktop: 'xsmall', tablet: 'xxsmall', mobile: 'xxsmall' }, | ||
| fontSizes = defaultFontSizes, |
abeddow91
reviewed
Mar 10, 2026
Comment on lines
+145
to
+150
| headlineSizes={{ | ||
| ...headlineSizes, | ||
| wide: isInSlimHomepageAbTestVariant | ||
| ? headlineSizes.tablet | ||
| : headlineSizes.desktop, | ||
| }} |
abeddow91
reviewed
Mar 10, 2026
Comment on lines
+20
to
+36
| /** | ||
| * This is temporarily commmented out so that we can review this in a 0% test. | ||
| * There is currently a container above News on the UK front, which means the test won't run. | ||
| * We will only start this test once News is again the top container, but in the meantime, we | ||
| * would like to be able to review this test. | ||
| */ | ||
| // const isFirstCollectionNews = | ||
| // collections[0]?.displayName.toLowerCase() === 'news'; | ||
| const hasRequiredCollections = | ||
| hasRequiredSlimHomepageAbTestCollections(collections); | ||
|
|
||
| return ( | ||
| pageId === 'uk' && | ||
| !hasPageSkin && | ||
| // isFirstCollectionNews && | ||
| hasRequiredCollections | ||
| ); |
abeddow91
approved these changes
Mar 10, 2026
|
Seen on PROD (merged by @domlander 8 minutes and 56 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Why?
We are now aligned on how we will run the AB test. We will have a control and two variants:
Screenshots